Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(nebula_node_container): support Nebula single-node architecture #97

Closed

Conversation

mojomex
Copy link
Contributor

@mojomex mojomex commented Jul 18, 2024

Description

This PR makes the changes necessary to support the new Nebula single-node architecture.
These changes can be summarized as:

  • merge the separate Nebula nodes into one in the launch file
  • find and read default sensor config file in case none is specified. Parameters specified as arguments will override the values in the file

⚠️ This PR has to be merged in a coordinated manner with the corresponding PRs listed below. The timeline is currently being discussed.

Related links

Internal Tickets:

Depends on:

How was this PR tested?

  • TBA

Notes for reviewers

None.

Interface changes

None.

Effects on system behavior

Nebula should experience less packet loss & other issues. The hardware monitor is now launched when launch_driver is true (was not launched at all before). No other behavioral changes expected.

Pre-review checklist for the PR author

The PR author must check the checkboxes below when creating the PR.

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.

After all checkboxes are checked, anyone who has write access can merge the PR.

@mojomex mojomex self-assigned this Jul 18, 2024
@mojomex mojomex changed the title feat(nebula_node_container): support Nebula single-node architecture refactor(nebula_node_container): support Nebula single-node architecture Jul 18, 2024
Copy link

stale bot commented Sep 17, 2024

This pull request has been automatically marked as stale because it has not had recent activity.

@mojomex
Copy link
Contributor Author

mojomex commented Sep 30, 2024

@mojomex mojomex closed this Sep 30, 2024
@mojomex mojomex deleted the feat/nebula-single-node-support branch September 30, 2024 12:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant